From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann)
Date: Fri, 22 Aug 2008 13:32:04 +0200 [thread overview]
Message-ID: <48AEA3B4.5050300@redhat.com> (raw)
In-Reply-To: <48AE9963.5040603@siemens.com>
Hi,
>> } else {
>> + if (shutdown_requested)
>> + break;
>> timeout = 10;
> Could we define the policy that no patch is merged which introduces new
> compiler warnings?
Just double-checked. I don't get a warning for some strange reason.
Was wondered how a warning bypassed my attention.
You probably see "ret can be used uninitialized ...", right?
> --- a/vl.c
> +++ b/vl.c
> @@ -7624,8 +7624,10 @@ static int main_loop(void)
> timeout = 0;
> }
> } else {
> - if (shutdown_requested)
> + if (shutdown_requested) {
> + ret = EXCP_INTERRUPT;
> break;
> + }
Fix looks fine to me.
cheers,
Gerd
--
http://kraxel.fedorapeople.org/xenner/
next prev parent reply other threads:[~2008-08-22 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 20:08 [Qemu-devel] [5055] Handle terminating signals (Gerd Hoffmann) Anthony Liguori
2008-08-22 10:48 ` [Qemu-devel] " Jan Kiszka
2008-08-22 11:32 ` Gerd Hoffmann [this message]
2008-08-22 11:55 ` Jan Kiszka
2008-08-22 12:06 ` Gerd Hoffmann
2008-08-22 13:21 ` Jan Kiszka
2008-08-22 12:52 ` Anthony Liguori
2008-08-22 13:20 ` Jan Kiszka
2008-08-22 13:50 ` Anthony Liguori
2008-09-02 11:21 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AEA3B4.5050300@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).