From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KWVFK-0001nA-H9
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 07:56:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KWVFI-0001mk-6m
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 07:56:01 -0400
Received: from [199.232.76.173] (port=57308 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KWVFI-0001mh-0a
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 07:56:00 -0400
Received: from gecko.sbs.de ([194.138.37.40]:18369)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1KWVFH-00008R-8F
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 07:55:59 -0400
Received: from mail1.sbs.de (localhost [127.0.0.1])
	by gecko.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m7MBtu2v025596
	for <qemu-devel@nongnu.org>; Fri, 22 Aug 2008 13:55:57 +0200
Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167]
	(may be forged))
	by mail1.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m7MBtudJ023262
	for <qemu-devel@nongnu.org>; Fri, 22 Aug 2008 13:55:56 +0200
Message-ID: <48AEA94D.1080002@siemens.com>
Date: Fri, 22 Aug 2008 13:55:57 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <E1KWGRv-0004PS-DQ@cvs.savannah.gnu.org>	<48AE9963.5040603@siemens.com>
	<48AEA3B4.5050300@redhat.com>
In-Reply-To: <48AEA3B4.5050300@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
>   Hi,
> 
>>>          } else {
>>> +            if (shutdown_requested)
>>> +                break;
>>>              timeout = 10;
> 
>> Could we define the policy that no patch is merged which introduces new
>> compiler warnings?
> 
> Just double-checked.  I don't get a warning for some strange reason.
> Was wondered how a warning bypassed my attention.

I like colorgcc for this a lot (either distcc or icecream is said to
support this as well). :)

> 
> You probably see "ret can be used uninitialized ...", right?

Yep. Are you compiling qemu with gcc-3.3 (here: 3.3.3 hammer, x86_64 host)?

> 
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -7624,8 +7624,10 @@ static int main_loop(void)
>>                  timeout = 0;
>>              }
>>          } else {
>> -            if (shutdown_requested)
>> +            if (shutdown_requested) {
>> +                ret = EXCP_INTERRUPT;
>>                  break;
>> +            }
> 
> Fix looks fine to me.

So we don't need to bother about no_shutdown in this path?

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux