From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWWZU-0006MO-4j for qemu-devel@nongnu.org; Fri, 22 Aug 2008 09:20:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWWZQ-0006MC-Ha for qemu-devel@nongnu.org; Fri, 22 Aug 2008 09:20:54 -0400 Received: from [199.232.76.173] (port=54748 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWWZQ-0006M9-B1 for qemu-devel@nongnu.org; Fri, 22 Aug 2008 09:20:52 -0400 Received: from gecko.sbs.de ([194.138.37.40]:18549) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KWWZQ-0005rO-2s for qemu-devel@nongnu.org; Fri, 22 Aug 2008 09:20:52 -0400 Received: from mail1.sbs.de (localhost [127.0.0.1]) by gecko.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m7MDKm2k016223 for ; Fri, 22 Aug 2008 15:20:48 +0200 Received: from [139.25.109.167] (mchn012c.ww002.siemens.net [139.25.109.167] (may be forged)) by mail1.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m7MDKmtX006427 for ; Fri, 22 Aug 2008 15:20:48 +0200 Message-ID: <48AEBD30.40008@siemens.com> Date: Fri, 22 Aug 2008 15:20:48 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <48AE9963.5040603@siemens.com> <48AEB69D.40501@codemonkey.ws> In-Reply-To: <48AEB69D.40501@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > Jan Kiszka wrote: >> Could we define the policy that no patch is merged which introduces new >> compiler warnings? Fix below remove the one caused by the hunk above, >> but it still leaves some doubts for the semi-informed reader because the >> "if (shutdown_requested)" block under vm_running also checks for >> no_shutdown. Please confirm that leaving it out here was by intention. >> > > I do check for warnings. The version of GCC I'm using (3.4.6 20060404 > (Red Hat 3.4.6-9)) does not complain about these things. We probably > should add -Wall to the build and take the time to fix up all of the > warnings that occur. Makes /me wonder why 3.4 thinks there is no problem here (while this is obviously wrong). Being lazy and SuSE-based (which only provides a 3.3.3 for such legacy use cases, IIRC), and also remembering vaguely that there used to be warnings about 3.4 /wrt qemu, I kept 3.3.3. BTW, do you also check for 64-bit issues? My feeling is that this - at least - used to be a rare host platform for qemu contributors. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux