From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWX2u-0006ye-Bf for qemu-devel@nongnu.org; Fri, 22 Aug 2008 09:51:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWX2n-0006se-QP for qemu-devel@nongnu.org; Fri, 22 Aug 2008 09:51:16 -0400 Received: from [199.232.76.173] (port=54394 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWX2n-0006sb-Jy for qemu-devel@nongnu.org; Fri, 22 Aug 2008 09:51:13 -0400 Received: from an-out-0708.google.com ([209.85.132.251]:46452) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KWX2n-0002fx-9s for qemu-devel@nongnu.org; Fri, 22 Aug 2008 09:51:13 -0400 Received: by an-out-0708.google.com with SMTP id d18so110028and.130 for ; Fri, 22 Aug 2008 06:51:12 -0700 (PDT) Message-ID: <48AEC423.4030105@codemonkey.ws> Date: Fri, 22 Aug 2008 08:50:27 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann) References: <48AE9963.5040603@siemens.com> <48AEB69D.40501@codemonkey.ws> <48AEBD30.40008@siemens.com> In-Reply-To: <48AEBD30.40008@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jan Kiszka wrote: > Anthony Liguori wrote: > >> I do check for warnings. The version of GCC I'm using (3.4.6 20060404 >> (Red Hat 3.4.6-9)) does not complain about these things. We probably >> should add -Wall to the build and take the time to fix up all of the >> warnings that occur. >> > > Makes /me wonder why 3.4 thinks there is no problem here (while this is > obviously wrong). > > Being lazy and SuSE-based (which only provides a 3.3.3 for such legacy > use cases, IIRC), and also remembering vaguely that there used to be > warnings about 3.4 /wrt qemu, I kept 3.3.3. > Could just be that more warnings are enabled by default with your particular version of GCC. > BTW, do you also check for 64-bit issues? My feeling is that this - at > least - used to be a rare host platform for qemu contributors. > I run a 64-bit host. I run Fedora 9 x86_64. I have as many optional libraries installed as possible. I also have a mingw32 cross compiler setup that I use to test the windows build. The mingw32 compiler is gcc4 and throws an awful lot of warnings. Regards, Anthony Liguori > Jan > >