From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KWYCF-0005pV-OR
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 11:05:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KWYCD-0005mV-F5
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 11:05:02 -0400
Received: from [199.232.76.173] (port=54243 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KWYCD-0005mM-BU
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 11:05:01 -0400
Received: from mx1.redhat.com ([66.187.233.31]:37987)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KWYCC-0008Ns-3c
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 11:05:00 -0400
Message-ID: <48AED58C.5020206@redhat.com>
Date: Fri, 22 Aug 2008 17:04:44 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.
References: <1219400728-20422-1-git-send-email-kraxel@redhat.com>
	<1219400728-20422-2-git-send-email-kraxel@redhat.com>
	<48AEC328.6040502@codemonkey.ws>
In-Reply-To: <48AEC328.6040502@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org

Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> The patch also adds a XenEvtOps struct with function pointers for the
>> xc_evtchn_* family, which is used to switch between libxenctrl and the
>> qemu implementation at runtime.  By default libxenctrl is used.
> 
> I suppose the QEMU implementation is to eventually eliminate the need
> for libxc?

Yes, for xen emulation (aka xenner).
When running on Xen libxc is still needed of course.

> Do you also plan on doing a XenStore implementation within QEMU?

Yes.

>> @@ -521,6 +521,7 @@ endif
>>  # xen backend driver support
>>  XEN_OBJS := xen_machine_pv.o xen_backend.o xen_devconfig.o
>> xen_domainbuild.o
>>  XEN_OBJS += xen_console.o xen_framebuffer.o xen_disk.o xen_nic.o
>> +XEN_OBJS += xenner_libxc_evtchn.o
> 
> Historically, we didn't have directories in QEMU because we used CVS and
> directories are a nightmare.  With the shear number of files being added
> for Xen, it probably makes sense to stick them all in a directory.

Hmm, the xen guys vetoed file renames, so I don't feel like sticking
stuff used by xen somewhere else.  For the emulation bits aka
xenner*.[ch] it should be no problem though.  New xenner/ toplevel
directory?

> Minor nit, make sure to have copyrights in all of your files.
> [ ... more review comments ... ]

Thanks, I'll fix it up.

cheers,
  Gerd