From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWay7-0000oa-9G for qemu-devel@nongnu.org; Fri, 22 Aug 2008 14:02:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWay6-0000ns-L4 for qemu-devel@nongnu.org; Fri, 22 Aug 2008 14:02:39 -0400 Received: from [199.232.76.173] (port=53647 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWay6-0000nl-I4 for qemu-devel@nongnu.org; Fri, 22 Aug 2008 14:02:38 -0400 Received: from wr-out-0506.google.com ([64.233.184.239]:2056) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KWay6-0003Yp-9V for qemu-devel@nongnu.org; Fri, 22 Aug 2008 14:02:38 -0400 Received: by wr-out-0506.google.com with SMTP id c46so581510wra.18 for ; Fri, 22 Aug 2008 11:02:36 -0700 (PDT) Message-ID: <48AEFF0F.7010700@codemonkey.ws> Date: Fri, 22 Aug 2008 13:01:51 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Check for gcc3 only if compiling dyngen targets References: <48AEFB48.3090606@reactos.org> In-Reply-To: <48AEFB48.3090606@reactos.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hervé Poussineau wrote: > Hi, > > If no configured target needs dyngen, gcc3.x is not required. Currently, > you have to explicitly pass --disable-gcc-check flag to allow compilation. > > Attached patch removes gcc check if no selected target needs dyngen. > I had to move gcc4 detection later in the configure script > This patch breaks gcc3 autodetection in a subtle way. You more the autodetect down much further after $cc is used to compile a bunch of test executables. gcc3 autodetection may change $cc so all of those compile tests are now invalid. I posted a patch a while ago that did basically the same thing but didn't suffer from this problem. Paul Brook basically Nacked it though as it's a lot of ugliness for little short term gain. Let's wait a bit longer and hope that the remaining targets get converted to TCG before doing a partial switch to gcc4. Regards, Anthony Liguori > Hervé >