From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXLQN-0001tk-5M
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 15:38:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXLQI-0001tC-Sx
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 15:38:54 -0400
Received: from [199.232.76.173] (port=40872 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXLQI-0001t8-Ou
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 15:38:50 -0400
Received: from mail-gx0-f23.google.com ([209.85.217.23]:50830)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KXLQI-0001j3-Du
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 15:38:50 -0400
Received: by gxk4 with SMTP id 4so1716972gxk.10
	for <qemu-devel@nongnu.org>; Sun, 24 Aug 2008 12:38:49 -0700 (PDT)
Message-ID: <48B1B89B.6060003@codemonkey.ws>
Date: Sun, 24 Aug 2008 14:38:03 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add VMware machine
References: <48B1894B.9000602@reactos.org>
In-Reply-To: <48B1894B.9000602@reactos.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hervé Poussineau wrote:
> Hi,
>
> Attached patch adds a 'vmware' machine type.
> This one automatically uses VMware display card, and enables VMware mouse.
>   

I really don't like the idea of proliferating machine types in the 
absence of a configuration file system.

> In non VMware machine types (ie 'pc' and 'isapc' types), VMware backdoor
> and VMware mouse are disabled [1]
>   

Why would we want to disable these things?

Regards,

Anthony Liguori

> I added an enum with PC types in pc.c . This system can be extended
> later to add more PC types.
>
> Please comment.
>
> Hervé
>
> [1] This has the same effect that the switch '-no-vmport' proposed by
> Ian Kirk in http://marc.info/?l=qemu-devel&m=121957847306185&w=2
>