qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.
Date: Mon, 25 Aug 2008 14:58:33 +0200	[thread overview]
Message-ID: <48B2AC79.7040002@redhat.com> (raw)
In-Reply-To: <48AED58C.5020206@redhat.com>

  Hi,

>>>  XEN_OBJS += xen_console.o xen_framebuffer.o xen_disk.o xen_nic.o
>>> +XEN_OBJS += xenner_libxc_evtchn.o
>> Historically, we didn't have directories in QEMU because we used CVS and
>> directories are a nightmare.  With the shear number of files being added
>> for Xen, it probably makes sense to stick them all in a directory.
> 
> Hmm, the xen guys vetoed file renames, so I don't feel like sticking
> stuff used by xen somewhere else.  For the emulation bits aka
> xenner*.[ch] it should be no problem though.  New xenner/ toplevel
> directory?

Comments on this one?

Another idea:  Do the initial merge in hw/, and later on, after the
qemu-xen tree catched up, move all xen (and xen emulation) bits to
another directory.  That would keep the scm revision history intact for
the Xen guys.

I also think we need to organize the source -- especially the header
files -- a bit better if we start to separate the code into more
subdirectories.  And I'd prefer to have some agreement on how the source
tree should look like before starting to shuffle around files, so I have
to do it only once ...

cheers,
  Gerd

  reply	other threads:[~2008-08-25 13:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22 10:25 [Qemu-devel] [PATCH 0/2] RfC: xenner (aka xen emulation) bits Gerd Hoffmann
2008-08-22 10:25 ` [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation Gerd Hoffmann
2008-08-22 13:46   ` Anthony Liguori
2008-08-22 15:04     ` Gerd Hoffmann
2008-08-25 12:58       ` Gerd Hoffmann [this message]
2008-08-25 14:15         ` Anthony Liguori
2008-08-25 15:12           ` [Xen-devel] " Keir Fraser
2008-08-25 17:57             ` Anthony Liguori
2008-08-25 18:42               ` Keir Fraser
2008-08-26  8:27                 ` Gerd Hoffmann
2008-08-26  8:40                   ` Keir Fraser
2008-08-26  8:39                 ` Daniel P. Berrange
2008-08-22 10:25 ` [Qemu-devel] [PATCH 2/2] xenner: use evtchn function pointers in the backends Gerd Hoffmann
     [not found] ` <m2n.s.1KWU8S-002Pyj@chiark.greenend.org.uk>
2008-08-26 11:02   ` [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation Ian Jackson
2008-08-26 13:13     ` Gerd Hoffmann
2008-08-26 13:28       ` Ian Jackson
2008-08-26 19:34         ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B2AC79.7040002@redhat.com \
    --to=kraxel@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).