From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXbgX-0007Te-VV for qemu-devel@nongnu.org; Mon, 25 Aug 2008 09:00:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXbgV-0007T3-VR for qemu-devel@nongnu.org; Mon, 25 Aug 2008 09:00:41 -0400 Received: from [199.232.76.173] (port=45711 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXbgT-0007Sg-S6 for qemu-devel@nongnu.org; Mon, 25 Aug 2008 09:00:38 -0400 Received: from mx2.redhat.com ([66.187.237.31]:41012) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXbgS-0007m0-Us for qemu-devel@nongnu.org; Mon, 25 Aug 2008 09:00:37 -0400 Message-ID: <48B2AC79.7040002@redhat.com> Date: Mon, 25 Aug 2008 14:58:33 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation. References: <1219400728-20422-1-git-send-email-kraxel@redhat.com> <1219400728-20422-2-git-send-email-kraxel@redhat.com> <48AEC328.6040502@codemonkey.ws> <48AED58C.5020206@redhat.com> In-Reply-To: <48AED58C.5020206@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Hi, >>> XEN_OBJS += xen_console.o xen_framebuffer.o xen_disk.o xen_nic.o >>> +XEN_OBJS += xenner_libxc_evtchn.o >> Historically, we didn't have directories in QEMU because we used CVS and >> directories are a nightmare. With the shear number of files being added >> for Xen, it probably makes sense to stick them all in a directory. > > Hmm, the xen guys vetoed file renames, so I don't feel like sticking > stuff used by xen somewhere else. For the emulation bits aka > xenner*.[ch] it should be no problem though. New xenner/ toplevel > directory? Comments on this one? Another idea: Do the initial merge in hw/, and later on, after the qemu-xen tree catched up, move all xen (and xen emulation) bits to another directory. That would keep the scm revision history intact for the Xen guys. I also think we need to organize the source -- especially the header files -- a bit better if we start to separate the code into more subdirectories. And I'd prefer to have some agreement on how the source tree should look like before starting to shuffle around files, so I have to do it only once ... cheers, Gerd