From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXd0U-0001Bq-L4
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:25:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXd0T-0001Ae-Lh
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:25:22 -0400
Received: from [199.232.76.173] (port=57913 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXd0T-0001AP-Gc
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:25:21 -0400
Received: from wr-out-0506.google.com ([64.233.184.236]:48880)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KXd0T-0002mR-Bv
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:25:21 -0400
Received: by wr-out-0506.google.com with SMTP id c46so1597662wra.18
	for <qemu-devel@nongnu.org>; Mon, 25 Aug 2008 07:25:20 -0700 (PDT)
Message-ID: <48B2C0A1.7040309@codemonkey.ws>
Date: Mon, 25 Aug 2008 09:24:33 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS
	communication.
References: <20080825095800.18703.30602.stgit@gleb-debian.qumranet.com.qumranet.com>
	<20080825095805.18703.63202.stgit@gleb-debian.qumranet.com.qumranet.com>
In-Reply-To: <20080825095805.18703.63202.stgit@gleb-debian.qumranet.com.qumranet.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>

Gleb Natapov wrote:
> Use PIO to get configuration info between qemu process and guest BIOS.
>
> Signed-off-by: Gleb Natapov <gleb@qumranet.com>
> ---
>
>  hw/pc.c |   59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 59 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 213ead8..8caa48f 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -44,6 +44,7 @@
>  
>  /* Leave a chunk of memory at the top of RAM for the BIOS ACPI tables.  */
>  #define ACPI_DATA_SIZE       0x10000
> +#define BIOS_CFG_IOPORT 0x1234
>  
>  #define MAX_IDE_BUS 2
>  
> @@ -53,6 +54,26 @@ static PITState *pit;
>  static IOAPICState *ioapic;
>  static PCIDevice *i440fx_state;
>  
> +typedef struct _BIOSCfgEntry {
> +    uint16_t len;
> +    uint8_t *data;
> +} BIOSCfgEntry;
>   

So why aren't we using the ROM mechanism suggested by Blue Swirl?  
Unless we're switching other firmwares to use this mechanism, I think it 
would be better to have a single QEMU<->firmware interface that we could 
support for all architectures.

Regards,

Anthony Liguori