From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXy7F-00057r-7I for qemu-devel@nongnu.org; Tue, 26 Aug 2008 08:57:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXy7E-00057c-3p for qemu-devel@nongnu.org; Tue, 26 Aug 2008 08:57:44 -0400 Received: from [199.232.76.173] (port=44368 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXy7E-00057Z-0Y for qemu-devel@nongnu.org; Tue, 26 Aug 2008 08:57:44 -0400 Received: from mx2.redhat.com ([66.187.237.31]:40369) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXy7D-0000ZO-Nn for qemu-devel@nongnu.org; Tue, 26 Aug 2008 08:57:44 -0400 Message-ID: <48B3FD5A.4040005@redhat.com> Date: Tue, 26 Aug 2008 14:55:54 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 13/13] xen: pv domain builder. References: <1219336054-15919-1-git-send-email-kraxel@redhat.com> <18611.56835.635884.646447@mariner.uk.xensource.com> In-Reply-To: <18611.56835.635884.646447@mariner.uk.xensource.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Ian Jackson wrote: > These kind of patches are rather troublesome I'm afraid. > > However in practice these changes are going to make it harder to merge > the existing Xen code, because they do some but not all of the same > things in a different way. If these patches are merged into qemu > upstream then I'll have to do a lot of untangling. If the patches break something, report it and I'll fix it up. "I'm afraid something might break" doesn't help us going forward. > What I would prefer is if Gerd would submit a patch or patches to > xen-devel, against our qemu, to factor out of the functionality needed > by his code. This should be done in a way that is both suitable for > his needs and structurally sensible for the xen upstream tree. http://kraxel.fedorapeople.org/patches/qemu-xen/ http://lists.xensource.com/archives/html/xen-devel/2008-08/msg00887.html cheers, Gerd