From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXyOV-00027K-1e
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 09:15:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXyOU-00026b-As
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 09:15:34 -0400
Received: from [199.232.76.173] (port=41619 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXyOT-000264-Sd
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 09:15:33 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54218)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KXyOT-0004vK-M5
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 09:15:33 -0400
Message-ID: <48B40184.5040908@redhat.com>
Date: Tue, 26 Aug 2008 15:13:40 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.
References: <1219400728-20422-1-git-send-email-kraxel@redhat.com>	<m2n.s.1KWU8S-002Pyj@chiark.greenend.org.uk>
	<18611.58069.185496.122923@mariner.uk.xensource.com>
In-Reply-To: <18611.58069.185496.122923@mariner.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org

Ian Jackson wrote:
> Gerd Hoffmann writes ("[Qemu-devel] [PATCH 1/2] xenner: add event channel implementation."):
>> The patch also adds a XenEvtOps struct with function pointers for the
>> xc_evtchn_* family, which is used to switch between libxenctrl and the
>> qemu implementation at runtime.  By default libxenctrl is used.
> 
> I don't understand why it's necessary to switch between these two
> modes at runtime.  That adds a lot of extra boilerplate and
> indirection code and probably has some tiny performance effect too.
> 
> Why not make it a compile-time option ?

IMHO compile time options are a usability nightmare in most cases.

Note that in another mail you've asked for a command line switch for
qemu to enable xen emulation mode even when running on xen.  That
wouldn't work any more if we would make this a compile time option.  You
would have to go and rebuild qemu first.

Also distrubutions would have to ship two binaries instead of one.  And
there are already way to much different qemu binaries today.  I want to
get that number down, not up.

cheers,
  Gerd