From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXz1D-0001pR-DC for qemu-devel@nongnu.org; Tue, 26 Aug 2008 09:55:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXz1C-0001nG-6n for qemu-devel@nongnu.org; Tue, 26 Aug 2008 09:55:34 -0400 Received: from [199.232.76.173] (port=56397 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXz1C-0001n3-14 for qemu-devel@nongnu.org; Tue, 26 Aug 2008 09:55:34 -0400 Received: from mx2.redhat.com ([66.187.237.31]:44111) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXz1B-00078w-PD for qemu-devel@nongnu.org; Tue, 26 Aug 2008 09:55:34 -0400 Message-ID: <48B40AE8.3070008@redhat.com> Date: Tue, 26 Aug 2008 15:53:44 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 13/13] xen: pv domain builder. References: <1219336054-15919-1-git-send-email-kraxel@redhat.com> <18611.56835.635884.646447@mariner.uk.xensource.com> <48B3FD5A.4040005@redhat.com> <18612.439.24867.23222@mariner.uk.xensource.com> In-Reply-To: <18612.439.24867.23222@mariner.uk.xensource.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Hi, >> http://kraxel.fedorapeople.org/patches/qemu-xen/ > > Those patches are not suitable for inclusion in qemu-xen. This is > because > - They rename files pointlessly You havn't looked at them in detail for a while, right? The pointless xen_* -> xen-* renames are all gone. Only one is left: Rename xenfb.c to xen_framebuffer.c for consistency with the other xen files. > - They contain many changes which consist of the addition of new > code which is not relevant for qemu-xen. Feel free to just ignore them. In theory they should be a no-op anyway, but I though you'd prefer to be able to test that. If you don't want that, fine, I'll happily drop the patches then. Less work for me, which is always welcome. > It is fine for us to > change qemu-xen to make it easier for your tree and our tree to > converge (such as factoring the backend driver core out of the > qemu-xen xenfb). Fine. > But we do not want (for example) your complete > backend driver set. You'll get them from upstream at some point anyway. If you don't want them beforehand for testing just tell me, no problem. > - http://kraxel.fedorapeople.org/patches/qemu-xen/0001-kraxel-s-stuff.patch > "Kraxel's Stuff" ? This is a joke, right ? Yea, the very first is just some script-age for me, ignore that one. Patches 02 -> 04 pull depending patches, once you've merged with upstream they are not needed any more and will be removed from the patch set. Patches 05 -> 09 is the backend core / console / framebuffer stuff you are willing to take. Patch 10 are the xen_machine_pv.c changes (upstream changeset has this earlier, moved here for better bisectability). Patch 11+ are disk + nic backends. Ignore them if you don't want them. > This has been explained before, I think ? Please read the patches and also the introduction text for the patch sets posted to xen-devel and qemu-devel. I *do* address your review comments. cheers, Gerd