From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXzEf-0002Sy-MN for qemu-devel@nongnu.org; Tue, 26 Aug 2008 10:09:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXzEd-0002QO-Ts for qemu-devel@nongnu.org; Tue, 26 Aug 2008 10:09:28 -0400 Received: from [199.232.76.173] (port=35144 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXzEd-0002Q0-Nr for qemu-devel@nongnu.org; Tue, 26 Aug 2008 10:09:27 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53974) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXzEd-0003HN-0J for qemu-devel@nongnu.org; Tue, 26 Aug 2008 10:09:27 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m7QE8o43011096 for ; Tue, 26 Aug 2008 10:09:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m7QE8dGB013285 for ; Tue, 26 Aug 2008 10:08:40 -0400 Received: from zweiblum.travel.kraxel.org (vpn-4-43.str.redhat.com [10.32.4.43]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m7QE8X4G004033 for ; Tue, 26 Aug 2008 10:08:34 -0400 Message-ID: <48B40E60.8090203@redhat.com> Date: Tue, 26 Aug 2008 16:08:32 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch 1/2] add pci config space struct References: <48B3DD9E.3060905@redhat.com> <48B3F624.2060502@qumranet.com> In-Reply-To: <48B3F624.2060502@qumranet.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Avi Kivity wrote: > Gerd Hoffmann wrote: >> +struct pci_config_header { >> + uint16_t vendor_id; > Shouldn't little-endian types be used here to force the users to use > little-endian accessors? Didn't notice qemu has that. Which header file I should check? There is nothing in bswap.h ... thanks, Gerd