From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYIea-0000im-Gh for qemu-devel@nongnu.org; Wed, 27 Aug 2008 06:53:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYIeX-0000hW-QV for qemu-devel@nongnu.org; Wed, 27 Aug 2008 06:53:31 -0400 Received: from [199.232.76.173] (port=55579 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYIeX-0000hP-DH for qemu-devel@nongnu.org; Wed, 27 Aug 2008 06:53:29 -0400 Received: from mx2.redhat.com ([66.187.237.31]:55413) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYIeW-00071O-Vn for qemu-devel@nongnu.org; Wed, 27 Aug 2008 06:53:29 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m7RAqlEc017038 for ; Wed, 27 Aug 2008 06:53:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m7RAqa95030027 for ; Wed, 27 Aug 2008 06:52:36 -0400 Received: from zweiblum.travel.kraxel.org (vpn-4-120.str.redhat.com [10.32.4.120]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m7RAqTbD000708 for ; Wed, 27 Aug 2008 06:52:30 -0400 Message-ID: <48B531ED.2090003@redhat.com> Date: Wed, 27 Aug 2008 12:52:29 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch 1/2] add pci config space struct References: <48B3DD9E.3060905@redhat.com> <48B3F624.2060502@qumranet.com> <48B40E60.8090203@redhat.com> <48B4194A.20107@qumranet.com> In-Reply-To: <48B4194A.20107@qumranet.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Avi Kivity wrote: > Gerd Hoffmann wrote: >>> Shouldn't little-endian types be used here to force the users to use >>> little-endian accessors? >>> >> >> Didn't notice qemu has that. Which header file I should check? There >> is nothing in bswap.h ... > > I don't think qemu has them; it should though. Adding byteordered types is a completely separate issue IMHO. > I'd define le32 (and friends) as a struct to ensure it is impossible to > misuse. Sure, that is the usual way ;) I expected you suggest to just use something which is present already though. cheers, Gerd