From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYLp2-0001GZ-6Z for qemu-devel@nongnu.org; Wed, 27 Aug 2008 10:16:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYLp1-0001GF-22 for qemu-devel@nongnu.org; Wed, 27 Aug 2008 10:16:31 -0400 Received: from [199.232.76.173] (port=51128 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYLp0-0001G7-T0 for qemu-devel@nongnu.org; Wed, 27 Aug 2008 10:16:30 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:41636) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KYLp0-0004pC-I3 for qemu-devel@nongnu.org; Wed, 27 Aug 2008 10:16:30 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m7RE7HgV027115 for ; Wed, 27 Aug 2008 10:07:17 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7RE77UL1212478 for ; Wed, 27 Aug 2008 10:07:12 -0400 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7RE72XR031335 for ; Wed, 27 Aug 2008 08:07:02 -0600 Message-ID: <48B55F59.303@us.ibm.com> Date: Wed, 27 Aug 2008 09:06:17 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1219783486-20209-1-git-send-email-aliguori@us.ibm.com> <18613.9097.941852.329602@mariner.uk.xensource.com> In-Reply-To: <18613.9097.941852.329602@mariner.uk.xensource.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH][RFC] Use signalfd() to work around signal/select race Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson Cc: qemu-devel@nongnu.org, Gerd Hoffman Ian Jackson wrote: > Anthony Liguori writes ("[PATCH][RFC] Use signalfd() to work around signal/select race"): > >> Here's my patch to work around the signal/select race. I think it cleans up >> the code quite nicely. While signalfd() is Linux-bias, I think it's a nice >> interface and the emulation isn't too bad. >> >> I've only lightly tested. I'm looking to see what people's reaction would be >> to this. >> > > For the avoidance of any doubt, following my criticisms of Anthony's > approach: I think it's essential that we have at least one of > Anthony's or my fixes to this problem. > > Obviously I prefer my patch because I wrote it, but other people might > prefer it because it's textually much smaller, closer to the existing > code, and doesn't use threads. > > Also, my patch has been pretty thoroughly tested, including some > performance stress testing, as part of the Xen 3.3.0 release. > FWIW, I still don't see your patch. It's not on gmane so I don't think it's a problem on my side. Regards, Anthony Liguori > Ian. >