From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYMdD-00037C-HU for qemu-devel@nongnu.org; Wed, 27 Aug 2008 11:08:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYMdB-000370-5c for qemu-devel@nongnu.org; Wed, 27 Aug 2008 11:08:22 -0400 Received: from [199.232.76.173] (port=51577 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYMdA-00036x-VA for qemu-devel@nongnu.org; Wed, 27 Aug 2008 11:08:20 -0400 Received: from mx2.redhat.com ([66.187.237.31]:45826) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYMdA-00031K-7A for qemu-devel@nongnu.org; Wed, 27 Aug 2008 11:08:20 -0400 Message-ID: <48B56D8D.7050002@redhat.com> Date: Wed, 27 Aug 2008 17:06:53 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch] add byteordered types References: <48B53E23.5040107@redhat.com> <200808271456.57273.paul@codesourcery.com> <48B56645.60206@redhat.com> <20080827.084738.-674761106.imp@bsdimp.com> In-Reply-To: <20080827.084738.-674761106.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "M. Warner Losh" Cc: qemu-devel@nongnu.org M. Warner Losh wrote: > In message: <48B56645.60206@redhat.com> > Gerd Hoffmann writes: > : Paul Brook wrote: > : > On Wednesday 27 August 2008, Gerd Hoffmann wrote: > : >> +static inline le16 write_le16(uint16_t cpu) \ > : > > : > This is IMHO a bad name for this function. It doesn't write anything. > : > : I'm not that happy the name too and certainly open for better > : suggestions I could use instead of read/write. > : > : The alternatives I can think of are not very nice either: > : > : (1) get/set -- same problem as read/write. > : (2) make_foo() instead of write_foo() -- "make" is too generic IMHO. > : (3) create_foo() instead of write_foo() -- no nice symmetric > : replacement for read_foo(). > : > : better ideas anyone? > > Using the existing names that linux/FreeBSD/NetBSD/OpenBSD are using? cpu_to_* is taken already by the not-typechecked macros. And converting the whole qemu tree in one go so we could reuse the names is a bit unrealistic IMHO. cheers, Gerd