From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [patch] add byteordered types
Date: Wed, 27 Aug 2008 18:20:09 +0200 [thread overview]
Message-ID: <48B57EB9.2050106@redhat.com> (raw)
In-Reply-To: <48B5778E.8000709@codemonkey.ws>
Anthony Liguori wrote:
> Personally, I dislike the whole struct thing. I even further dislike
> having multiple sets of conversion functions that are used in different
> places in the code.
>
> Are we sure that this is something that we want to do?
As far I know this struct trick is the only way to have gcc check access
to variables with an specific byteorder is done the correct way. Avi
sguuested that and I also think this checking would be useful. I could
live without that though if there is an agreement that we'll just stick
with the current, unchecked cpu_to_<order><size> functions.
cheers,
Gerd
next prev parent reply other threads:[~2008-08-27 16:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 11:44 [Qemu-devel] [patch] add byteordered types Gerd Hoffmann
2008-08-27 12:20 ` Paul Brook
2008-08-27 13:04 ` Gerd Hoffmann
2008-08-27 13:24 ` Gerd Hoffmann
2008-08-27 13:55 ` Paul Brook
2008-08-27 14:12 ` M. Warner Losh
2008-08-27 13:56 ` Paul Brook
2008-08-27 14:35 ` Gerd Hoffmann
2008-08-27 14:47 ` M. Warner Losh
2008-08-27 15:06 ` Gerd Hoffmann
2008-08-27 15:49 ` Anthony Liguori
2008-08-27 16:20 ` Gerd Hoffmann [this message]
2008-08-27 17:57 ` Anthony Liguori
2008-08-28 8:36 ` Gerd Hoffmann
2008-08-27 18:19 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B57EB9.2050106@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).