From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYNrs-0003zu-CJ for qemu-devel@nongnu.org; Wed, 27 Aug 2008 12:27:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYNrq-0003z6-Ip for qemu-devel@nongnu.org; Wed, 27 Aug 2008 12:27:35 -0400 Received: from [199.232.76.173] (port=39738 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYNrq-0003z2-9E for qemu-devel@nongnu.org; Wed, 27 Aug 2008 12:27:34 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42200) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYNrf-0004Eh-Iy for qemu-devel@nongnu.org; Wed, 27 Aug 2008 12:27:34 -0400 Message-ID: <48B57EB9.2050106@redhat.com> Date: Wed, 27 Aug 2008 18:20:09 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch] add byteordered types References: <48B53E23.5040107@redhat.com> <200808271456.57273.paul@codesourcery.com> <48B56645.60206@redhat.com> <20080827.084738.-674761106.imp@bsdimp.com> <48B56D8D.7050002@redhat.com> <48B5778E.8000709@codemonkey.ws> In-Reply-To: <48B5778E.8000709@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Paul Brook Anthony Liguori wrote: > Personally, I dislike the whole struct thing. I even further dislike > having multiple sets of conversion functions that are used in different > places in the code. > > Are we sure that this is something that we want to do? As far I know this struct trick is the only way to have gcc check access to variables with an specific byteorder is done the correct way. Avi sguuested that and I also think this checking would be useful. I could live without that though if there is an agreement that we'll just stick with the current, unchecked cpu_to_ functions. cheers, Gerd