From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYPFi-0007lh-2I for qemu-devel@nongnu.org; Wed, 27 Aug 2008 13:56:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYPFf-0007kb-7Q for qemu-devel@nongnu.org; Wed, 27 Aug 2008 13:56:17 -0400 Received: from [199.232.76.173] (port=54354 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYPFf-0007kU-3x for qemu-devel@nongnu.org; Wed, 27 Aug 2008 13:56:15 -0400 Received: from ag-out-0708.google.com ([72.14.246.251]:34004) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYPFe-0001vc-Ea for qemu-devel@nongnu.org; Wed, 27 Aug 2008 13:56:14 -0400 Received: by ag-out-0708.google.com with SMTP id 31so7128344agc.5 for ; Wed, 27 Aug 2008 10:56:13 -0700 (PDT) Message-ID: <48B5950D.20107@codemonkey.ws> Date: Wed, 27 Aug 2008 12:55:25 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 01/13] Handle terminating signals. References: <18611.63711.631859.280983@mariner.uk.xensource.com> <48B4027C.1000008@codemonkey.ws> <18612.1900.73781.314743@mariner.uk.xensource.com> <48B41B7E.40708@codemonkey.ws> <18612.7267.832361.270651@mariner.uk.xensource.com> <48B41F55.1000909@codemonkey.ws> <18612.8502.305043.233934@mariner.uk.xensource.com> <48B422F2.1090900@codemonkey.ws> <20080826174729.GB25893@shareable.org> <18613.8801.187470.178088@mariner.uk.xensource.com> <20080827162719.GC25387@shareable.org> <18613.33339.351040.938403@mariner.uk.xensource.com> In-Reply-To: <18613.33339.351040.938403@mariner.uk.xensource.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com, Gerd Hoffmann Ian Jackson wrote: > Jamie Lokier writes ("Re: [Xen-devel] Re: [Qemu-devel] [PATCH 01/13] Handle terminating signals."): > > Yes. Err, I'm not sure what effect that will have in Anthony's patch > but it probably wouldn't be good. > > As I say I haven't managed to reproduce this other than in a full > qemu-dm tree (from qemu-xen). > > So it may be that it is because of something I did or something the > qemu-xen code does - although it seems hard to imagine how it could > break the signal mask in the helper thread given that that thread runs > entirely glibc code, except when a signal is being delivered (and of > course the signal mask is saved and restored for signal delivery). > Perhaps the signal is being consumed in one of qemu-dm's other threads mistakenly? What you're describing would seem like a serious bug. For a while, I was testing a version of QEMU/KVM that slept forever in select() and I never saw any instances of the signal not getting delivered. Regards, Anthony Liguori > Ian. > > >