* [Qemu-devel] [PATCH] Do not try to use -net user as a default when slirp disabled.
@ 2008-08-28 16:44 Ian Jackson
2008-08-28 20:04 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Ian Jackson @ 2008-08-28 16:44 UTC (permalink / raw)
To: qemu-devel
When CONFIG_SLIRP is not defined, we should not try to use
-net user as a default.
Patch from Jeremy Fitzhardinge <jeremy@goop.org> (who is a Citrix
staff member).
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
vl.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index f1d92c1..81f7d8f 100644
--- a/vl.c
+++ b/vl.c
@@ -8370,9 +8370,10 @@ int main(int argc, char **argv)
/* init network clients */
if (nb_net_clients == 0) {
/* if no clients, we use a default config */
- net_clients[0] = "nic";
- net_clients[1] = "user";
- nb_net_clients = 2;
+ net_clients[nb_net_clients++] = "nic";
+#ifdef CONFIG_SLIRP
+ net_clients[nb_net_clients++] = "user";
+#endif
}
for(i = 0;i < nb_net_clients; i++) {
--
1.4.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Do not try to use -net user as a default when slirp disabled.
2008-08-28 16:44 [Qemu-devel] [PATCH] Do not try to use -net user as a default when slirp disabled Ian Jackson
@ 2008-08-28 20:04 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2008-08-28 20:04 UTC (permalink / raw)
To: qemu-devel
Ian Jackson wrote:
> When CONFIG_SLIRP is not defined, we should not try to use
> -net user as a default.
>
> Patch from Jeremy Fitzhardinge <jeremy@goop.org> (who is a Citrix
> staff member).
>
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-28 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-28 16:44 [Qemu-devel] [PATCH] Do not try to use -net user as a default when slirp disabled Ian Jackson
2008-08-28 20:04 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).