Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around broken Linux headers

[Anthony Liguori <anthony@codemonkey.ws>]

Ian Jackson wrote:
> Really we would like to #include <linux/compiler.h> but according
> to changelogs in xen-unstable, at least FC6R3 doesn't have it.
>
> So instead we do this: we  #define __user  ourselves, which is
> what <linux/compiler.h> does on systems which are not broken.
>
> (This change is identical to xen-unstable
>  11601:ba7487569374378b398a1b134ea108a6a8209b4b.
>  and qemu-xen 1f153e0706851b43bb5c2083e531fd7b64b75be1.)
>   

This was applied at one point in time, but then reverted IIRC.  I think 
Fabrice objected?

Regards,

Anthony Liguori

> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  usb-linux.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/usb-linux.c b/usb-linux.c
> index c31d56a..db51fe6 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -33,6 +33,9 @@
>  #if defined(__linux__)
>  #include <dirent.h>
>  #include <sys/ioctl.h>
> +/* Some versions of usbdevice_fs.h need __user to be defined for them.   */
> +/* This may (harmlessly) conflict with a definition in linux/compiler.h. */
> +#define __user
>  #include <linux/usbdevice_fs.h>
>  #include <linux/version.h>
>  #include <signal.h>
>