From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KYnlv-0003JE-FV
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 16:07:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KYnlo-0003Ge-Qe
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 16:07:10 -0400
Received: from [199.232.76.173] (port=51973 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KYnlo-0003GY-Jr
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 16:07:04 -0400
Received: from ag-out-0708.google.com ([72.14.246.251]:56256)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KYnln-0001BA-P4
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 16:07:04 -0400
Received: by ag-out-0708.google.com with SMTP id 31so1441010agc.5
	for <qemu-devel@nongnu.org>; Thu, 28 Aug 2008 13:07:00 -0700 (PDT)
Message-ID: <48B70534.40103@codemonkey.ws>
Date: Thu, 28 Aug 2008 15:06:12 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around
	broken Linux headers
References: <18614.53575.679530.36194@mariner.uk.xensource.com>
In-Reply-To: <18614.53575.679530.36194@mariner.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Ian Jackson wrote:
> Really we would like to #include <linux/compiler.h> but according
> to changelogs in xen-unstable, at least FC6R3 doesn't have it.
>
> So instead we do this: we  #define __user  ourselves, which is
> what <linux/compiler.h> does on systems which are not broken.
>
> (This change is identical to xen-unstable
>  11601:ba7487569374378b398a1b134ea108a6a8209b4b.
>  and qemu-xen 1f153e0706851b43bb5c2083e531fd7b64b75be1.)
>   

This was applied at one point in time, but then reverted IIRC.  I think 
Fabrice objected?

Regards,

Anthony Liguori

> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  usb-linux.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/usb-linux.c b/usb-linux.c
> index c31d56a..db51fe6 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -33,6 +33,9 @@
>  #if defined(__linux__)
>  #include <dirent.h>
>  #include <sys/ioctl.h>
> +/* Some versions of usbdevice_fs.h need __user to be defined for them.   */
> +/* This may (harmlessly) conflict with a definition in linux/compiler.h. */
> +#define __user
>  #include <linux/usbdevice_fs.h>
>  #include <linux/version.h>
>  #include <signal.h>
>