From: Avi Kivity <avi@qumranet.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, apevec@redhat.com,
qemu-devel@nongnu.org, chrisw@sous-sol.org,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] Fix up pxe boot
Date: Tue, 02 Sep 2008 11:39:13 +0300 [thread overview]
Message-ID: <48BCFBB1.4090109@qumranet.com> (raw)
In-Reply-To: <1220303503-19413-1-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
> index 0b5fdc0..433aa3f 100644
> --- a/target-i386/op_helper.c
> +++ b/target-i386/op_helper.c
> @@ -600,7 +600,7 @@ do {\
> #define PUSHL(ssp, sp, sp_mask, val)\
> {\
> sp -= 4;\
> - stl_kernel((ssp) + (sp & (sp_mask)), (val));\
> + stl_kernel((uint32_t)((ssp) + (sp & (sp_mask))), (uint32_t)(val));\
> }
>
Surly it is better to push this into the underlying virtual->physical
translation functions, so it applies everywhere?
btw, the cast is wrong for x86-64, so it must be qualified for 32-bit
operating modes.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-02 9:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 21:11 [Qemu-devel] [PATCH] Fix up pxe boot Glauber Costa
2008-09-02 8:39 ` Avi Kivity [this message]
2008-09-02 11:07 ` [Qemu-devel] " Glauber Costa
2008-09-02 15:20 ` Avi Kivity
2008-09-02 15:22 ` Glauber Costa
2008-09-03 19:27 ` Glauber Costa
2008-09-07 6:42 ` Avi Kivity
2008-09-08 15:38 ` Glauber Costa
2008-09-09 14:17 ` Avi Kivity
2008-09-09 14:48 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BCFBB1.4090109@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=apevec@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=ehabkost@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).