From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] Re: [5140] hw/pcnet.c: windows compile fix
Date: Wed, 03 Sep 2008 13:16:22 +0200 [thread overview]
Message-ID: <48BE7206.4090402@siemens.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0809031217530.13830@pacific.mpi-cbg.de.mpi-cbg.de>
Johannes Schindelin wrote:
> Hi,
>
> On Tue, 2 Sep 2008, Aurelien Jarno wrote:
>
>> Log Message:
>> -----------
>> hw/pcnet.c: windows compile fix
>>
>> (Eduardo Felipe)
>>
>> Modified Paths:
>> --------------
>> trunk/hw/pcnet.c
>>
>> Modified: trunk/hw/pcnet.c
>> ===================================================================
>> --- trunk/hw/pcnet.c 2008-09-02 17:39:45 UTC (rev 5139)
>> +++ trunk/hw/pcnet.c 2008-09-02 23:26:13 UTC (rev 5140)
>> @@ -35,7 +35,11 @@
>> * http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR92C990.txt
>> */
>>
>> +#ifdef _WIN32
>> +#include <winsock2.h>
>> +#else
>> #include <netinet/in.h>
>> +#endif
>
> Was the idea not to use the header file "qemu_socket.h" instead?
Sounds reasonable to me.
Jan
Index: qemu/hw/pcnet.c
===================================================================
--- qemu/hw/pcnet.c (Revision 5144)
+++ qemu/hw/pcnet.c (Arbeitskopie)
@@ -35,16 +35,11 @@
* http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR92C990.txt
*/
-#ifdef _WIN32
-#include <winsock2.h>
-#else
-#include <netinet/in.h>
-#endif
-
#include "hw.h"
#include "pci.h"
#include "net.h"
#include "qemu-timer.h"
+#include "qemu_socket.h"
//#define PCNET_DEBUG
//#define PCNET_DEBUG_IO
next prev parent reply other threads:[~2008-09-03 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 23:26 [Qemu-devel] [5140] hw/pcnet.c: windows compile fix Aurelien Jarno
2008-09-03 10:19 ` Johannes Schindelin
2008-09-03 11:16 ` Jan Kiszka [this message]
2008-09-04 4:35 ` [Qemu-devel] " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BE7206.4090402@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).