* [Qemu-devel] [PATCH] Fix warning
@ 2008-09-06 13:00 Hervé Poussineau
2008-09-14 16:19 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Hervé Poussineau @ 2008-09-06 13:00 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
Hi,
Attached patch fixes a warning in cpu_mips_find_by_name().
'name' is a string, so it should be declared as char*, not unsigned char*.
Hervé
[-- Attachment #2: fix signed warning.diff --]
[-- Type: text/plain, Size: 400 bytes --]
Index: target-mips/translate_init.c
===================================================================
--- target-mips/translate_init.c (revision 5171)
+++ target-mips/translate_init.c (working copy)
@@ -417,7 +417,7 @@
#endif
};
-static const mips_def_t *cpu_mips_find_by_name (const unsigned char *name)
+static const mips_def_t *cpu_mips_find_by_name (const char *name)
{
int i;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] Fix warning
2008-09-06 13:00 [Qemu-devel] [PATCH] Fix warning Hervé Poussineau
@ 2008-09-14 16:19 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2008-09-14 16:19 UTC (permalink / raw)
To: qemu-devel
On Sat, Sep 06, 2008 at 03:00:02PM +0200, Hervé Poussineau wrote:
> Hi,
>
> Attached patch fixes a warning in cpu_mips_find_by_name().
> 'name' is a string, so it should be declared as char*, not unsigned char*.
Applied, thanks
> Hervé
> Index: target-mips/translate_init.c
> ===================================================================
> --- target-mips/translate_init.c (revision 5171)
> +++ target-mips/translate_init.c (working copy)
> @@ -417,7 +417,7 @@
> #endif
> };
>
> -static const mips_def_t *cpu_mips_find_by_name (const unsigned char *name)
> +static const mips_def_t *cpu_mips_find_by_name (const char *name)
> {
> int i;
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-14 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-06 13:00 [Qemu-devel] [PATCH] Fix warning Hervé Poussineau
2008-09-14 16:19 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).