From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kc9u2-0005sW-J1 for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:21:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kc9u0-0005s8-C4 for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:21:25 -0400 Received: from [199.232.76.173] (port=47322 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kc9u0-0005s5-6N for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:21:24 -0400 Received: from ag-out-0708.google.com ([72.14.246.249]:19697) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kc9tz-00007x-VF for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:21:24 -0400 Received: by ag-out-0708.google.com with SMTP id 31so2683072agc.5 for ; Sat, 06 Sep 2008 19:21:23 -0700 (PDT) Message-ID: <48C33A72.4040502@codemonkey.ws> Date: Sat, 06 Sep 2008 21:20:34 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/3] [x86] Add Core 2 Duo CPU specification v4 References: <48AEF258.5020509@suse.de> In-Reply-To: <48AEF258.5020509@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Alexander Graf wrote: > Hi, > > this set of patches attempts to implement a CPU definition set for > current Intel CPUs that resembles an original as closely as currently > possible. Several features a current Intel CPU has are not implemented > by qemu, but that should not keep us from adding this definition so > people can add features later on. > > As a side effect, I made the sysenter instruction 64-bit aware. This was > an issue in KVM, that used the 32-bit cpu struct variables to hold > 64-bit MSR values sysenter needs. I believe it to be a step in the > right direction to not fix this only for KVM, but make the functionality > available to qemu as well. I'm generally uncomfortable with this series because it starts advertising things to guests that are not actually implemented. How would you feel about splitting out some of the sysenter fixes and general cleanups but keeping the vendor identification out of tree? Regards, Anthony Liguori > Version 2 adds save/load. Only the sysenter implementation has changed. > Version 3 pushes the series from -p2 to -p1 > Version 4 fixes a stupid typo (bels instead of betls) > > Alex > > > >