From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kc9v1-0006J7-Sp for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:22:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kc9v0-0006I5-1P for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:22:27 -0400 Received: from [199.232.76.173] (port=47326 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kc9uz-0006I2-SH for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:22:25 -0400 Received: from an-out-0708.google.com ([209.85.132.246]:56004) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kc9uz-0000Ds-Fn for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:22:25 -0400 Received: by an-out-0708.google.com with SMTP id d18so162779and.130 for ; Sat, 06 Sep 2008 19:22:25 -0700 (PDT) Message-ID: <48C33AB0.7000706@codemonkey.ws> Date: Sat, 06 Sep 2008 21:21:36 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH, RFC] gcc -Wredundant-decls References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl wrote: > The first patch enables gcc flag -Wredundant-decls, the second one > fixes the warnings caused by it. Again, with the flag enabled, dyngen > targets output a lot of useless warnings, so it should be enabled > later. Applying the fixing patch should be safe. > You may have applied them already, but they both look sane to me. Regards, Anthony Liguori > Comments? >