From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KcA6n-0007Z9-9i for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:34:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KcA6l-0007Tn-5c for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:34:36 -0400 Received: from [199.232.76.173] (port=39672 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcA6k-0007TR-Uo for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:34:34 -0400 Received: from ag-out-0708.google.com ([72.14.246.247]:24410) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcA6k-0001oh-LF for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:34:34 -0400 Received: by ag-out-0708.google.com with SMTP id 31so2687727agc.5 for ; Sat, 06 Sep 2008 19:34:34 -0700 (PDT) Message-ID: <48C33D89.9000805@codemonkey.ws> Date: Sat, 06 Sep 2008 21:33:45 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS communication. References: <20080825095805.18703.63202.stgit@gleb-debian.qumranet.com.qumranet.com> <48B2C0A1.7040309@codemonkey.ws> <20080825144026.GQ6192@minantech.com> <48B2F373.1020606@codemonkey.ws> <20080826082453.GV6192@minantech.com> <20080827110522.GX6192@minantech.com> <20080828052953.GC9450@minantech.com> In-Reply-To: <20080828052953.GC9450@minantech.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Gleb Natapov wrote: > On Wed, Aug 27, 2008 at 08:10:49PM +0300, Blue Swirl wrote: > >> On 8/27/08, Gleb Natapov wrote: >> >>> On Tue, Aug 26, 2008 at 07:46:20PM +0300, Blue Swirl wrote: >>> > > Is the patch below what you mean? (not tested, but compiles) >>> > >>> > Yes, but I'd still put the code from the .h file and pc.c to a new .c >>> > file, only the keys and function prototypes to .h. >>> > >>> >>> Okey, here is updated one (compiled only) >>> >> I added some missing pieces like static/const keywords, device >> save/load and reset, MMIO and Sparc32/64 support. I also renamed some >> names for consistency. >> > Thanks! I'll rebase my other patches on this and will test it. > I think this is missing save/restore support. What happens if you do a save, move to a different machine, then do a restore, and reboot? The guest will see a different value IIUC. Also, instead of returning 0 on non-linux systems, why not just return some fixed value? It's no more "wrong" than returning the host clock rate. Regards, Anthony Liguori > -- > Gleb. > > >