From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcACJ-0001Ru-1I
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:40:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcACH-0001NT-DY
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:40:18 -0400
Received: from [199.232.76.173] (port=39826 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KcACH-0001ND-3t
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:40:17 -0400
Received: from an-out-0708.google.com ([209.85.132.248]:59085)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KcACG-0002SK-JP
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:40:16 -0400
Received: by an-out-0708.google.com with SMTP id d18so163171and.130
	for <qemu-devel@nongnu.org>; Sat, 06 Sep 2008 19:40:16 -0700 (PDT)
Message-ID: <48C33EDF.4090305@codemonkey.ws>
Date: Sat, 06 Sep 2008 21:39:27 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/4] pci: add default pci subsystem id for
	all devices.
References: <1219912589-12476-1-git-send-email-kraxel@redhat.com>
	<1219912589-12476-3-git-send-email-kraxel@redhat.com>
	<48B70C8D.2030003@codemonkey.ws> <48B7BBE5.3090107@redhat.com>
In-Reply-To: <48B7BBE5.3090107@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> Anthony Liguori wrote:
>   
>>> TODO: get an official vendor ID assigned, or borrow one (maybe
>>>       Qumranet which already sponsors the virtio IDs ???).
>>>       
>> Does the subvendor ID have to be an official vendor ID?
>>     
>
> I think so, as far I know there is no difference between vendor and
> subvendor ID in that respect.
>
>   
>> I thought that
>> the subvendor ID could be defined by the vendor as whatever it wants..
>>     
>
> Each vendor can assign the device (and subdevice) IDs freely.
>   

It's worth looking into because in virtio, we currently define the 
subvendor ID to be not the PCI vendor ID space.  I'll try to dig up a 
copy of the PCI spec and confirm.  If it's not required to be the PCI 
vendor ID space, then this patch is unnecessary.  We can just set it to 
a non-0 value of our choosing.

Regards,

Anthony Liguori

> cheers,
>   Gerd
>
>
>