From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [RESEND] wrap up use of dangerous ctype.h macros
Date: Sat, 06 Sep 2008 21:49:07 -0500 [thread overview]
Message-ID: <48C34123.5030201@codemonkey.ws> (raw)
In-Reply-To: <18615.50309.943540.583772@mariner.uk.xensource.com>
Ian Jackson wrote:
> Anthony Liguori writes ("Re: [Qemu-devel] [PATCH] [RESEND] wrap up use of dangerous ctype.h macros"):
>
>> Can't we just have qemu_isspace() macros? I find the CTYPE macro quite
>> awkward. I don't think most people are comfortable with that kind of
>> syntax.
>>
>
> I don't have a strong opinion about this. But of course qemu_isspace
> et al would require us to list in qemu-common.h all of the isfoobar
> and towombat functions.
>
At least, the ones we actually use. I'd definitely prefer this.
Regards,
Anthony Liguori
> Ian.
>
>
>
prev parent reply other threads:[~2008-09-07 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 16:24 [Qemu-devel] [PATCH] wrap up use of dangerous ctype.h macros Ian Jackson
2008-08-28 17:21 ` [Qemu-devel] [PATCH] [RESEND] " Ian Jackson
2008-08-28 20:22 ` Anthony Liguori
2008-08-29 9:42 ` Ian Jackson
2008-09-07 2:49 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C34123.5030201@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).