From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcALg-0004Dr-U6
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:50:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcALe-0004Cj-VK
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:50:00 -0400
Received: from [199.232.76.173] (port=36072 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KcALe-0004Cd-Hn
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:49:58 -0400
Received: from an-out-0708.google.com ([209.85.132.250]:56803)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KcALd-0003UQ-Qe
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:49:58 -0400
Received: by an-out-0708.google.com with SMTP id d18so163401and.130
	for <qemu-devel@nongnu.org>; Sat, 06 Sep 2008 19:49:56 -0700 (PDT)
Message-ID: <48C34123.5030201@codemonkey.ws>
Date: Sat, 06 Sep 2008 21:49:07 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] [RESEND] wrap up use of dangerous ctype.h
	macros
References: <18364.21555.874570.784725@mariner.uk.xensource.com>	<18614.56999.66982.389605@mariner.uk.xensource.com>	<48B708F1.9080300@codemonkey.ws>
	<18615.50309.943540.583772@mariner.uk.xensource.com>
In-Reply-To: <18615.50309.943540.583772@mariner.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Ian Jackson wrote:
> Anthony Liguori writes ("Re: [Qemu-devel] [PATCH] [RESEND] wrap up use of dangerous ctype.h macros"):
>   
>> Can't we just have qemu_isspace() macros?  I find the CTYPE macro quite 
>> awkward.  I don't think most people are comfortable with that kind of 
>> syntax.
>>     
>
> I don't have a strong opinion about this.  But of course qemu_isspace
> et al would require us to list in qemu-common.h all of the isfoobar
> and towombat functions.
>   

At least, the ones we actually use.  I'd definitely prefer this.

Regards,

Anthony Liguori

> Ian.
>
>
>