From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcAMr-0004XS-4S
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:51:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcAMp-0004W9-EQ
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:51:12 -0400
Received: from [199.232.76.173] (port=36087 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KcAMp-0004Vw-88
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:51:11 -0400
Received: from an-out-0708.google.com ([209.85.132.246]:59331)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KcAMo-0003cg-Em
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 22:51:10 -0400
Received: by an-out-0708.google.com with SMTP id d18so163434and.130
	for <qemu-devel@nongnu.org>; Sat, 06 Sep 2008 19:51:10 -0700 (PDT)
Message-ID: <48C3416D.2050305@codemonkey.ws>
Date: Sat, 06 Sep 2008 21:50:21 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around
	broken Linux headers
References: <18614.53575.679530.36194@mariner.uk.xensource.com>	<48B70534.40103@codemonkey.ws>	<20080828204114.GD3229@networkno.de>
	<18615.50622.311395.372416@mariner.uk.xensource.com>
In-Reply-To: <18615.50622.311395.372416@mariner.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: qemu-devel@nongnu.org

Ian Jackson wrote:
> Thiemo Seufer writes ("Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around broken Linux headers"):
>   
>> It was rejected because distros should fix their broken headers instead.
>>     
>
> I think this is an absurd response.
>   

I tend to agree with you.  I think the proper fix though is not to 
#define __user but to copy the Linux headers into QEMU and made sure 
they compiled properly.  I would apply a patch that did that.

Regards,

Anthony Liguori