From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcAWc-0000OE-JS
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 23:01:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcAWb-0000MG-2P
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 23:01:18 -0400
Received: from [199.232.76.173] (port=49695 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KcAWa-0000MD-Tj
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 23:01:16 -0400
Received: from an-out-0708.google.com ([209.85.132.251]:57805)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KcAWa-0004dD-Ez
	for qemu-devel@nongnu.org; Sat, 06 Sep 2008 23:01:16 -0400
Received: by an-out-0708.google.com with SMTP id d18so163649and.130
	for <qemu-devel@nongnu.org>; Sat, 06 Sep 2008 20:01:15 -0700 (PDT)
Message-ID: <48C343CB.2000208@codemonkey.ws>
Date: Sat, 06 Sep 2008 22:00:27 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [REPOST] [PATCH 0/2] IDE error checking
References: <18620.5409.570126.428085@mariner.uk.xensource.com>
In-Reply-To: <18620.5409.570126.428085@mariner.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Ian Jackson wrote:
> In these two patches I make the IDE controller emulation pay attention
> to errors returned by the bdrv functions.
>
> The first of these patches was first posted in February 2008 and has
> been discussed extensively.
>
> There was some discussion as to whether it would be better, in cases
> where the error was ENOSPC, to stop the guest than to pass it an IDE
> error.  However it must be clear that regardless of whether that would
> be better in some circumstances, giving the guest an IDE error is
> better than silently ignoring the error, throwing away the guest's
> data.
>   

The proper solution is not significantly more difficult.  Just add a 
switch(errno) { case ENOSPC: vm_stop(0); term_printf("Ran out of disk 
space\n"); break; }.  That's all I'm asking for.

Regards,

Anthony Liguori

> I would therefore submit that my patch should be applied immediately.
> If anyone wants to implement automatic stopping of guests on ENOSPC
> errors this should then be done as an optional enhancement.
>
> In this patch pair I don't fix the call to bdrv_flush in FLUSH CACHE.
> This is because that's entangled with another dropped series of
> patches to implement use of aio for cache flushing and guest control
> of the host write cache.
>
> Ian.
>
>
>