qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Xen patches - status summary
Date: Sat, 06 Sep 2008 22:16:15 -0500	[thread overview]
Message-ID: <48C3477F.4080205@codemonkey.ws> (raw)
In-Reply-To: <18625.2823.334560.150430@mariner.uk.xensource.com>

Ian Jackson wrote:
> Anthony Liguori writes ("Re: [Qemu-devel] Xen patches - status summary"):
>
> I think the rule should generally be that a patch should be applied if
> it (a) makes some improvement, no matter how minor and (b) does not
> make any future desirable restructuring harder.  The fact that a
> restructuring is desirable does not mean that minor improvements
> should be blocked in the meantime.
>   

There's a balance between band-aid fixing and making forward progress in 
improving things.  Honestly, you've spent more time writing emails 
trying to avoid adding special handling for ENOSPC than it would have 
taken to just update the original patch.

Reporting an IDE error on ENOSPC is just plain wrong.  It doesn't matter 
if already broken and you're just changing how it's broken.  It's not 
like it's a massive effort to update the patch.  I'll eventually get to 
it myself but it's a whole lot easier for you to just do it and then we 
can move on to more important things :-)

Regards,

Anthony Liguori

> Ian.
>
>
>   

  parent reply	other threads:[~2008-09-07  3:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-02 16:44 [Qemu-devel] Xen patches - status summary Ian Jackson
2008-09-03 18:43 ` Gerd Hoffmann
2008-09-04  2:47   ` Anthony Liguori
2008-09-05 10:33     ` Ian Jackson
2008-09-06 22:00       ` Anthony Liguori
2008-09-07  3:16       ` Anthony Liguori [this message]
2008-09-04  2:53 ` Anthony Liguori
2008-09-05 10:23   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C3477F.4080205@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).