From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcUVU-0000QL-Sp
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 20:21:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcUVT-0000Q7-D0
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 20:21:28 -0400
Received: from [199.232.76.173] (port=36871 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KcUVT-0000Q4-8U
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 20:21:27 -0400
Received: from an-out-0708.google.com ([209.85.132.245]:13897)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KcUVT-0001XM-00
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 20:21:27 -0400
Received: by an-out-0708.google.com with SMTP id d18so200685and.130
	for <qemu-devel@nongnu.org>; Sun, 07 Sep 2008 17:21:26 -0700 (PDT)
Message-ID: <48C46FD4.7020905@codemonkey.ws>
Date: Sun, 07 Sep 2008 19:20:36 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] pcnet: add loopback mode emulation
References: <48BD26AF.7050404@siemens.com>
In-Reply-To: <48BD26AF.7050404@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>

Jan Kiszka wrote:
> This patch enhances the pcnet NIC emulation with better loopback mode
> support, including CRC generation for looped-back packets in "raw" mode.
> The patch has practically no impact on the normal RX and TX path.
>
> Successfully tested against an ancient proprietary pcnet driver that
> does a lot of hardware checks on boot-up and now works fine over qemu as
> well.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/pcnet.c |   89 ++++++++++++++++++++++++++++++++++++++++---------------------
>  1 file changed, 59 insertions(+), 30 deletions(-)
>
> Index: b/hw/pcnet.c
> ===================================================================
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -35,6 +35,8 @@
>   * http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR92C990.txt
>   */
>  
> +#include <netinet/in.h>
>
>   

That'll break the windows build.  It's not immediately clear to me why 
you're including netinet/in.h.  Is it for htonl?  I think arpa/inet.h is 
where htonl is defined...

At any rate, qemu_socket.h is probably what you want, but I'd like to 
know why you're adding it in the first place.

Regards,

Anthony Liguori