From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcUwC-0004Ia-2R
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 20:49:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcUw9-0004IC-IU
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 20:49:02 -0400
Received: from [199.232.76.173] (port=49559 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KcUw9-0004I7-DS
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 20:49:01 -0400
Received: from ag-out-0708.google.com ([72.14.246.251]:30729)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KcUw9-0005wf-1w
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 20:49:01 -0400
Received: by ag-out-0708.google.com with SMTP id 31so3472064agc.5
	for <qemu-devel@nongnu.org>; Sun, 07 Sep 2008 17:49:00 -0700 (PDT)
Message-ID: <48C4764B.2060008@codemonkey.ws>
Date: Sun, 07 Sep 2008 19:48:11 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4 of 5] sdl shared buffer support
References: <48BFF045.2030303@eu.citrix.com>
In-Reply-To: <48BFF045.2030303@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Stefano Stabellini wrote:
> This patch implements shared buffer support in sdl.c.
> It also supports paletted 8 bit colour depths using the
> palette functions provided by the SDL library.
>   

So the theory goes that it's possible with this patch that both surfaces 
are hardware surfaces so blitting is fast?  In practice, when using X11 
both surfaces are going to be XShmImages so I don't think this is going 
to perform any better than the current code.

Do you have any sort of measurements that show an advantage with this patch?

I sort of think you want the opposite interface.  One where the VGA code 
uses ds->data directly if the guest ds->data is in a supportable format.

Regards,

Anthony Liguori