From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KccM8-00027Q-SR
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 04:44:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KccM7-00025B-0q
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 04:44:20 -0400
Received: from [199.232.76.173] (port=55297 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KccM6-00024f-Id
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 04:44:18 -0400
Received: from lizzard.sbs.de ([194.138.37.39]:24190)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1KccM6-0008FH-4P
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 04:44:18 -0400
Message-ID: <48C4E5CE.9080608@siemens.com>
Date: Mon, 08 Sep 2008 10:43:58 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <486CF559.5090805@siemens.com>
	<48AC2E09.3030405@siemens.com>	<48AC2EE9.8050803@siemens.com>
	<48C33916.6010608@codemonkey.ws>
	<f43fc5580809071211p4134df99w760385dcb748f65e@mail.gmail.com>
In-Reply-To: <f43fc5580809071211p4134df99w760385dcb748f65e@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RESEND][PATCH 2/13] Refactor and enhance
 break/watchpoint API
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>, Paul Brook <paul@codesourcery.com>

Blue Swirl wrote:
> On 9/7/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> Does anyone have any objections to this series?  It literally touches every
>> architectures so I don't want to commit it without some Ack'ing for the
>> appropriate architecture maintainers.
> 
> Sparc part is OK.
> 
> +
> +#ifndef CONFIG_USER_ONLY
> +const int xlat_gdb_type[] = {
> +    [GDB_WATCHPOINT_WRITE]  = BP_GDB | BP_MEM_WRITE,
> 
> "static" missing.
> 

Yep, thanks, will fix.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux