From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KdQ1f-0001vM-DU
	for qemu-devel@nongnu.org; Wed, 10 Sep 2008 09:46:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KdQ1d-0001uf-Mg
	for qemu-devel@nongnu.org; Wed, 10 Sep 2008 09:46:30 -0400
Received: from [199.232.76.173] (port=50669 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KdQ1d-0001uY-HW
	for qemu-devel@nongnu.org; Wed, 10 Sep 2008 09:46:29 -0400
Received: from mx2.redhat.com ([66.187.237.31]:41654)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KdQ1d-0008U0-5u
	for qemu-devel@nongnu.org; Wed, 10 Sep 2008 09:46:29 -0400
Message-ID: <48C7CE5A.7070405@redhat.com>
Date: Wed, 10 Sep 2008 15:40:42 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/4] pci: add default pci subsystem id for
	all devices.
References: <1221047125-12949-1-git-send-email-kraxel@redhat.com>
	<1221047125-12949-3-git-send-email-kraxel@redhat.com>
	<200809101343.14760.paul@codesourcery.com>
In-Reply-To: <200809101343.14760.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

Paul Brook wrote:
> On Wednesday 10 September 2008, Gerd Hoffmann wrote:
>> +extern uint16_t pci_default_sub_vendor_id;
>> +extern uint16_t pci_default_sub_device_id;
> 
> Why are these being exported?

So you can change the defaults.  Main user for that I have in mind is
Xen.  They have added a subsystem id (5853:0001, XenSource vendor ID) to
some of the devices (by patching the indiviudual drivers, not by adding
a global default like this patch does).

I expect they probably want to keep the XenSource subsystem ID instead
of going with the qemu default.  So the idea is that we can have "if
(using_xen) { make 5853:0001 the default }" in the initialization path
some day.

cheers,
  Gerd