qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Ryan Harper <ryanh@us.ibm.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH][RFC] Refactor AIO to allow multiple AIO implementations
Date: Thu, 11 Sep 2008 09:48:30 +0200	[thread overview]
Message-ID: <48C8CD4E.1020705@redhat.com> (raw)
In-Reply-To: <1221061788-26166-1-git-send-email-aliguori@us.ibm.com>

Anthony Liguori wrote:
> This patch refactors the AIO layer to allow multiple AIO implementations.  It's
> only possible because of the recent signalfd() patch.  
> 
> Right now, the AIO infrastructure is pretty specific to the block raw backend.
> For other block devices to implement AIO, the qemu_aio_wait function must support
> registration.  This patch introduces a new function, qmeu_aio_set_fd_handler, which
> can be used to register a file descriptor to be called back.  qemu_aio_wait() now
> polls a set of file descriptors registered with this function until one becomes
> readable or writable.

Hmm, what is the long-term plan for this?  Separating out the completion
notification is a nice first step.  Most of the aio infrastructure is
still in the block raw backend though.  IMHO it doesn't belong there.

The aio implementation(s) should be a separate entity usable by all
block backends to invoke aio requests, without having to care about how
this is actually implemented (threads, linux aio, posix aio, whatever).

cheers,
  Gerd

  reply	other threads:[~2008-09-11  7:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 15:49 [Qemu-devel] [PATCH][RFC] Refactor AIO to allow multiple AIO implementations Anthony Liguori
2008-09-11  7:48 ` Gerd Hoffmann [this message]
2008-09-11 12:45   ` [Qemu-devel] " Anthony Liguori
2008-09-11 13:15     ` Gerd Hoffmann
2008-09-11 13:28       ` Jamie Lokier
2008-09-11 14:09         ` Anthony Liguori
2008-09-11 14:04       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C8CD4E.1020705@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ryanh@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).