From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KdjgD-0007qe-Si
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 06:45:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KdjgA-0007oe-7K
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 06:45:39 -0400
Received: from [199.232.76.173] (port=46123 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kdjg9-0007nh-68
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 06:45:37 -0400
Received: from smtp.eu.citrix.com ([62.200.22.115]:57686)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1Kdjg8-0006xr-Dd
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 06:45:36 -0400
Message-ID: <48C8F730.3000201@eu.citrix.com>
Date: Thu, 11 Sep 2008 11:47:12 +0100
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1 of 6] [UPDATE] vnc dynamic resolution
References: <48C54E82.1090104@eu.citrix.com> <48C7E341.7060604@codemonkey.ws>
In-Reply-To: <48C7E341.7060604@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Anthony Liguori wrote:

> 
> When testing this patch, gvncviewer hangs when attempting to connect. 
> It's waiting to receive the ServerPixelFormat and it doesn't appear to
> receive it.


I admit I didn't test the patch individually but only the full series at
once.
The reality is that the first patch doesn't make any sense without the
fourth.
Actually now that I split the shared buffer patch into two patches: the
shared buffer in vga.c and the vnc implementation, it would even make
sense to merge the first patch and the fourth.
I'll repost the full series that way, if you agree:

1) shared buffer (vga only and interfaces)
2) shared buffer vnc implementation
3) WMVi implementation in vnc
4) shared buffer sdl implementation
5) opengl rendering implementation

I could even merge 2) and 3) if you prefer.

>> @@ -1318,7 +1440,9 @@ static int protocol_client_init(VncState *vs,
>> uint8_t *data, size_t len)
>>      vnc_write_u16(vs, vs->ds->height);
>>  
>>      vnc_write_u8(vs, vs->depth * 8); /* bits-per-pixel */
>> -    vnc_write_u8(vs, vs->depth * 8); /* depth */
>> +    if (vs->depth == 4) vnc_write_u8(vs, 24); /* depth */
>> +    else vnc_write_u8(vs, vs->depth * 8); /* depth */
>>   
> 
> Why unconditionally change to a depth of 24 instead of 32?  There's no
> savings from a protocol perspective.
> 

I guess this change is not really needed, it is only to better specify
that the format is RGB, 1 byte per channel plus 1 byte for the unused
alpha channel.