qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1 of 6] [UPDATE] vnc dynamic resolution
Date: Thu, 11 Sep 2008 11:58:56 +0100	[thread overview]
Message-ID: <48C8F9F0.4000801@eu.citrix.com> (raw)
In-Reply-To: <48C7E341.7060604@codemonkey.ws>

Anthony Liguori wrote:

> When testing this patch, gvncviewer hangs when attempting to connect. 
> It's waiting to receive the ServerPixelFormat and it doesn't appear to
> receive it.

The patch "doesn't work" as it is because of a little initialization
problem: in vnc_display_init you need to call

vnc_colordepth(vs->ds, 32);

before

vnc_dpy_resize(vs->ds, 640, 400);

The vnc display initialization is changed anyway with the fourth patch
(see my previous post).

If you want me to resend the series with this issue fixed, do you want
the first and the fourth patch split or merged?

  parent reply	other threads:[~2008-09-11 10:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08 16:10 [Qemu-devel] [PATCH 1 of 6] [UPDATE] vnc dynamic resolution Stefano Stabellini
2008-09-10 15:09 ` Anthony Liguori
2008-09-11 10:47   ` Stefano Stabellini
2008-09-11 10:58   ` Stefano Stabellini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-12 11:26 Stefano Stabellini
2008-09-15 16:04 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C8F9F0.4000801@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).