From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KdjrJ-0002xu-6J
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 06:57:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KdjrI-0002xG-19
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 06:57:08 -0400
Received: from [199.232.76.173] (port=57239 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KdjrH-0002wy-BH
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 06:57:07 -0400
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:21305
	helo=SMTP.EU.CITRIX.COM)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1KdjrG-0001Hs-Rh
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 06:57:07 -0400
Message-ID: <48C8F9F0.4000801@eu.citrix.com>
Date: Thu, 11 Sep 2008 11:58:56 +0100
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1 of 6] [UPDATE] vnc dynamic resolution
References: <48C54E82.1090104@eu.citrix.com> <48C7E341.7060604@codemonkey.ws>
In-Reply-To: <48C7E341.7060604@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Anthony Liguori wrote:

> When testing this patch, gvncviewer hangs when attempting to connect. 
> It's waiting to receive the ServerPixelFormat and it doesn't appear to
> receive it.

The patch "doesn't work" as it is because of a little initialization
problem: in vnc_display_init you need to call

vnc_colordepth(vs->ds, 32);

before

vnc_dpy_resize(vs->ds, 640, 400);

The vnc display initialization is changed anyway with the fourth patch
(see my previous post).

If you want me to resend the series with this issue fixed, do you want
the first and the fourth patch split or merged?