From: Anthony Liguori <aliguori@us.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5194] Fix the build on non-Linux systems
Date: Thu, 11 Sep 2008 11:20:55 -0500 [thread overview]
Message-ID: <48C94567.6060104@us.ibm.com> (raw)
In-Reply-To: <f43fc5580809110906i4bf6e047s9ddc3fdc9db6d669@mail.gmail.com>
Blue Swirl wrote:
> On 9/11/08, C. W. Betts <computers57@hotmail.com> wrote:
>
>> Now it complains about missing symbols:
>> Undefined symbols:
>> "_sigwaitinfo", referenced from:
>> _sigwait_compat in compatfd.o
>> ld: symbol(s) not found
>> collect2: ld returned 1 exit status
>> make: *** [qemu-img] Error 1
>> This happened both when trying to compile qemu-img and qemu-nbd.
>>
>> On Sep 11, 2008, at 8:18 AM, Anthony Liguori wrote:
>>
>> Revision: 5194
>>
>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5194
>> Author: aliguori
>> Date: 2008-09-11 14:18:56 +0000 (Thu, 11 Sep 2008)
>>
>> Log Message:
>> -----------
>> Fix the build on non-Linux systems
>>
>> It turns out, we're never reading from the signalfd() which is causing it to
>> remain readable forever. I'll fix this up but I thought I'd commit this fix
>> in the interim.
>>
>
> On OpenBSD the final link fails because pthread symbols are missing.
>
Does this help:
Index: Makefile.target
===================================================================
--- Makefile.target (revision 5193)
+++ Makefile.target (working copy)
@@ -476,9 +476,13 @@
ifdef CONFIG_WIN32
OBJS+=block-raw-win32.o
else
-OBJS+=block-raw-posix.o compatfd.o
+OBJS+=block-raw-posix.o
endif
+ifdef CONFIG_AIO
+OBJS+=compatfd.o
+endif
+
LIBS+=-lz
ifdef CONFIG_ALSA
LIBS += -lasound
Index: Makefile
===================================================================
--- Makefile (revision 5193)
+++ Makefile (working copy)
@@ -177,9 +177,13 @@
ifdef CONFIG_WIN32
QEMU_IMG_BLOCK_OBJS += qemu-img-block-raw-win32.o
else
-QEMU_IMG_BLOCK_OBJS += nbd.o qemu-img-block-raw-posix.o compatfd.o
+QEMU_IMG_BLOCK_OBJS += nbd.o qemu-img-block-raw-posix.o
endif
+ifdef CONFIG_AIO
+QEMU_IMG_BLOCK_OBJS += compatfd.o
+endif
+
######################################################################
qemu-img$(EXESUF): qemu-img.o qemu-img-block.o $(QEMU_IMG_BLOCK_OBJS)
Index: configure
===================================================================
--- configure (revision 5193)
+++ configure (working copy)
@@ -1220,6 +1220,7 @@
fi
if test "$aio" = "yes" ; then
echo "#define CONFIG_AIO 1" >> $config_h
+ echo "CONFIG_AIO=yes" >> $config_mak
fi
# XXX: suppress that
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-09-11 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 14:18 [Qemu-devel] [5194] Fix the build on non-Linux systems Anthony Liguori
[not found] ` <97371528-A47E-441F-87C7-66A30BAC42E0@hotmail.com>
2008-09-11 15:26 ` C.W. Betts
2008-09-11 16:06 ` Blue Swirl
2008-09-11 16:15 ` Anthony Liguori
2008-09-11 16:57 ` Blue Swirl
2008-09-11 16:20 ` Anthony Liguori [this message]
2008-09-11 17:06 ` Blue Swirl
[not found] ` <F63B4C90-4303-4A11-BF72-BF36682000FD@hotmail.com>
2008-09-11 16:33 ` C.W. Betts
[not found] ` <9E6E4065-F682-414C-AB68-A565A5BF2B07@hotmail.com>
2008-09-11 17:10 ` C.W. Betts
2008-09-11 18:17 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C94567.6060104@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).