From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kdox7-0003D7-He for qemu-devel@nongnu.org; Thu, 11 Sep 2008 12:23:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kdox2-00038z-UP for qemu-devel@nongnu.org; Thu, 11 Sep 2008 12:23:27 -0400 Received: from [199.232.76.173] (port=57776 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kdox2-00038o-Hd for qemu-devel@nongnu.org; Thu, 11 Sep 2008 12:23:24 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:58355) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kdox2-0002cp-Dg for qemu-devel@nongnu.org; Thu, 11 Sep 2008 12:23:24 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e31.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m8BGLkRt013075 for ; Thu, 11 Sep 2008 12:21:46 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m8BGLkeG210556 for ; Thu, 11 Sep 2008 10:21:46 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m8BGLjY6013839 for ; Thu, 11 Sep 2008 10:21:46 -0600 Message-ID: <48C94567.6060104@us.ibm.com> Date: Thu, 11 Sep 2008 11:20:55 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [5194] Fix the build on non-Linux systems References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Blue Swirl wrote: > On 9/11/08, C. W. Betts wrote: > >> Now it complains about missing symbols: >> Undefined symbols: >> "_sigwaitinfo", referenced from: >> _sigwait_compat in compatfd.o >> ld: symbol(s) not found >> collect2: ld returned 1 exit status >> make: *** [qemu-img] Error 1 >> This happened both when trying to compile qemu-img and qemu-nbd. >> >> On Sep 11, 2008, at 8:18 AM, Anthony Liguori wrote: >> >> Revision: 5194 >> >> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5194 >> Author: aliguori >> Date: 2008-09-11 14:18:56 +0000 (Thu, 11 Sep 2008) >> >> Log Message: >> ----------- >> Fix the build on non-Linux systems >> >> It turns out, we're never reading from the signalfd() which is causing it to >> remain readable forever. I'll fix this up but I thought I'd commit this fix >> in the interim. >> > > On OpenBSD the final link fails because pthread symbols are missing. > Does this help: Index: Makefile.target =================================================================== --- Makefile.target (revision 5193) +++ Makefile.target (working copy) @@ -476,9 +476,13 @@ ifdef CONFIG_WIN32 OBJS+=block-raw-win32.o else -OBJS+=block-raw-posix.o compatfd.o +OBJS+=block-raw-posix.o endif +ifdef CONFIG_AIO +OBJS+=compatfd.o +endif + LIBS+=-lz ifdef CONFIG_ALSA LIBS += -lasound Index: Makefile =================================================================== --- Makefile (revision 5193) +++ Makefile (working copy) @@ -177,9 +177,13 @@ ifdef CONFIG_WIN32 QEMU_IMG_BLOCK_OBJS += qemu-img-block-raw-win32.o else -QEMU_IMG_BLOCK_OBJS += nbd.o qemu-img-block-raw-posix.o compatfd.o +QEMU_IMG_BLOCK_OBJS += nbd.o qemu-img-block-raw-posix.o endif +ifdef CONFIG_AIO +QEMU_IMG_BLOCK_OBJS += compatfd.o +endif + ###################################################################### qemu-img$(EXESUF): qemu-img.o qemu-img-block.o $(QEMU_IMG_BLOCK_OBJS) Index: configure =================================================================== --- configure (revision 5193) +++ configure (working copy) @@ -1220,6 +1220,7 @@ fi if test "$aio" = "yes" ; then echo "#define CONFIG_AIO 1" >> $config_h + echo "CONFIG_AIO=yes" >> $config_mak fi # XXX: suppress that Regards, Anthony Liguori