From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KdtJF-0006Sq-To
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 17:02:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KdtJE-0006Rc-6t
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 17:02:37 -0400
Received: from [199.232.76.173] (port=53573 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KdtJE-0006RY-1Q
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 17:02:36 -0400
Received: from an-out-0708.google.com ([209.85.132.245]:19840)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KdtJD-0006rY-Q3
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 17:02:35 -0400
Received: by an-out-0708.google.com with SMTP id d18so64911and.130
	for <qemu-devel@nongnu.org>; Thu, 11 Sep 2008 14:02:35 -0700 (PDT)
Message-ID: <48C98738.5060204@codemonkey.ws>
Date: Thu, 11 Sep 2008 16:01:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1220679644-8043-1-git-send-email-maxk@kernel.org>
In-Reply-To: <1220679644-8043-1-git-send-email-maxk@kernel.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] usb: Support for removing device by host
 addr, improved auto filter syntax
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Krasnyansky <maxk@kernel.org>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, kvm@vger.kernel.org

Max Krasnyansky wrote:
> This patch adds support for removing USB devices by host address.
> Which is usefull for things like libvirtd because there is no easy way to
> find guest USB address of the host device.
> In other words you can now do:
>    usb_add host:3.5
>    ...
>    usb_del host:3.5
> Before the patch 'usb_del' did not support 'host:' notation.
>
>   

This patch breaks the windows build with:

i686-pc-mingw32-gcc -Wall -O2 -g -fno-strict-aliasing  -m32 -I. 
-I/home/anthony/svn/qemu -MMD -MP -MT usb-linux.o -D_GNU_SOURCE 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-I/home/anthony/svn/qemu/slirp -c -o usb-linux.o 
/home/anthony/svn/qemu/usb-linux.c
/home/anthony/svn/qemu/usb-linux.c:1205: error: conflicting types for 
'usb_host_device_close'
/home/anthony/svn/qemu/hw/usb.h:243: error: previous declaration of 
'usb_host_device_close' was here
make: *** [usb-linux.o] Error 1

Regards,

Anthony Liguori