From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kdzev-0002oY-CL
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 23:49:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kdzet-0002oA-4J
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 23:49:24 -0400
Received: from [199.232.76.173] (port=57813 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kdzes-0002o7-VG
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 23:49:23 -0400
Received: from hera.kernel.org ([140.211.167.34]:41304)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <maxk@kernel.org>) id 1Kdzet-0000Xj-2g
	for qemu-devel@nongnu.org; Thu, 11 Sep 2008 23:49:23 -0400
Message-ID: <48C9E6A4.1070402@kernel.org>
Date: Thu, 11 Sep 2008 20:48:52 -0700
From: Max Krasnyansky <maxk@kernel.org>
MIME-Version: 1.0
References: <1220679644-8043-1-git-send-email-maxk@kernel.org>
	<48C98738.5060204@codemonkey.ws>
In-Reply-To: <48C98738.5060204@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] usb: Support for removing device by host
 addr, improved auto filter syntax
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, kvm@vger.kernel.org

Anthony Liguori wrote:
> Max Krasnyansky wrote:
>> This patch adds support for removing USB devices by host address.
>> Which is usefull for things like libvirtd because there is no easy way to
>> find guest USB address of the host device.
>> In other words you can now do:
>>    usb_add host:3.5
>>    ...
>>    usb_del host:3.5
>> Before the patch 'usb_del' did not support 'host:' notation.
>>
>>   
> 
> This patch breaks the windows build with:
> 
> i686-pc-mingw32-gcc -Wall -O2 -g -fno-strict-aliasing  -m32 -I.
> -I/home/anthony/svn/qemu -MMD -MP -MT usb-linux.o -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -I/home/anthony/svn/qemu/slirp -c -o usb-linux.o
> /home/anthony/svn/qemu/usb-linux.c
> /home/anthony/svn/qemu/usb-linux.c:1205: error: conflicting types for
> 'usb_host_device_close'
> /home/anthony/svn/qemu/hw/usb.h:243: error: previous declaration of
> 'usb_host_device_close' was here
> make: *** [usb-linux.o] Error 1

I'll take a look and resend. Thanx for testing.

Max