qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, gcosta@redhat.com
Subject: Re: [Qemu-devel] Re: [PATCH] Make page_find() return 0 for too-large addresses
Date: Fri, 12 Sep 2008 16:27:30 -0500	[thread overview]
Message-ID: <48CADEC2.3060204@codemonkey.ws> (raw)
In-Reply-To: <20080912204404.GB10147@blackpad>

Eduardo Habkost wrote:
> On Fri, Sep 12, 2008 at 05:14:06PM -0300, Eduardo Habkost wrote:
>   
>> On Fri, Sep 12, 2008 at 02:50:33PM -0500, Anthony Liguori wrote:
>>     
>>> Eduardo Habkost wrote:
>>>       
>>>> On some cases, such as under KVM, tb_invalidate_phys_page_range()
>>>> may be called for large addresses, when qemu is configured to more than
>>>> 4GB of RAM.
>>>>
>>>> On these cases, qemu was crashing because it was using an index too
>>>> large for l1_map[], that supports only 32-bit addresses when compiling
>>>> without CONFIG_USER_ONLY.
>>>>   
>>>>         
> <snip>
>   

So... are you building with kqemu enabled?  If so, 
TARGET_PHYS_ADDR_SPACE_BITS will be 32.  So I don't think this sort of 
work-around is correct.  A better solution would be to validate ram_size 
against TARGET_PHYS_ADDR_SPACE_BITS.

To put it another way, if you have kqemu enabled (at build time), you 
cannot use > ~4GB of memory for the guest.

Regards,

Anthony Liguori

  reply	other threads:[~2008-09-12 21:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-12 18:58 [Qemu-devel] [PATCH] Make page_find() return 0 for too-large addresses Eduardo Habkost
2008-09-12 19:50 ` [Qemu-devel] " Anthony Liguori
2008-09-12 20:14   ` Eduardo Habkost
2008-09-12 20:44     ` Eduardo Habkost
2008-09-12 21:27       ` Anthony Liguori [this message]
2008-09-12 21:47         ` Eduardo Habkost
2008-09-15 13:08         ` Glauber Costa
2008-09-15 15:29       ` Anthony Liguori
2008-09-15 15:48         ` Eduardo Habkost
2008-09-15 15:57           ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48CADEC2.3060204@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=ehabkost@redhat.com \
    --cc=gcosta@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).