From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KeXuj-00023G-23 for qemu-devel@nongnu.org; Sat, 13 Sep 2008 12:24:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KeXuf-00022o-I1 for qemu-devel@nongnu.org; Sat, 13 Sep 2008 12:24:00 -0400 Received: from [199.232.76.173] (port=55431 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KeXuf-00022l-Cg for qemu-devel@nongnu.org; Sat, 13 Sep 2008 12:23:57 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:63797) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KeXuf-0001C7-5p for qemu-devel@nongnu.org; Sat, 13 Sep 2008 12:23:57 -0400 Received: by gxk12 with SMTP id 12so20862839gxk.10 for ; Sat, 13 Sep 2008 09:23:56 -0700 (PDT) Message-ID: <48CBE8E8.9010208@codemonkey.ws> Date: Sat, 13 Sep 2008 11:23:04 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <48CB11EE.7040808@codemonkey.ws> <1221319815.4170.14.camel@frecb07144> In-Reply-To: <1221319815.4170.14.camel@frecb07144> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] Re: [PATCH][RFC][RFT] Let qemu-nbd build on Windows and replace QEMU_IMG/QEMU_NBD with QEMU_TOOL Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: "qemu-devel@nongnu.org" Laurent Vivier wrote: > Le vendredi 12 septembre 2008 à 20:05 -0500, Anthony Liguori a écrit : > >> This patch attempts to clean up the mess with qemu-nbd in the Makefile >> in order to get it building and working on Windows. I checked >> block-nbd, qemu-img, and qemu-nbd on Windows and Linux and everything >> seems to work. However, there were some defined(QEMU_IMG) that didn't >> include defined(QEMU_NBD) that now are covered by QEMU_TOOL so I'd like >> Laurent to look them over and see if they were intentional. >> > > If I remember correctly they were intentional: > - some of them because qemu-nbd didn't support windows (but you have > corrected this) > - others because qemu-img doesn't need to open file with O_DIRECT > whereas qemu-nbd must (--nocache option) (and I think you break this) > > Did you test "qemu-nbd --nocache" ? > No, but this is why I asked :-) So this begs the question, why does qemu-nbd need to open files with O_DIRECT and why doesn't qemu-img? Can we just enable the code in both? Regards, Anthony Liguori >> Basically, there are no longer qemu-nbd-*.o objects. qemu-img-*.o have >> -DQEMU_TOOL defined and qemu-img/qemu-nbd use identical copies of those >> objects. A special object is no longer build for nbd.c either. >> >> My longer goal would be to eliminate as many qemu-img-* objects as >> possible but let's take that one step at a time. >> > > I think it's a good idea... > > Regards, > Laurent >