From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KhmZy-0000LQ-IR
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 10:39:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KhmZx-0000L2-3v
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 10:39:58 -0400
Received: from [199.232.76.173] (port=52621 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KhmZw-0000Kz-VZ
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 10:39:56 -0400
Received: from ik-out-1112.google.com ([66.249.90.178]:2665)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KhmZw-0003UF-Ia
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 10:39:56 -0400
Received: by ik-out-1112.google.com with SMTP id c21so933177ika.2
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2008 07:39:54 -0700 (PDT)
Message-ID: <48D7ADFF.7060902@codemonkey.ws>
Date: Mon, 22 Sep 2008 09:38:55 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] add support for higher screen resolutions
References: <48D13550.8000707@gmx.at>
	<20080917200438.GC4204@implementation>	<loom.20080918T010618-51@post.gmane.org>
	<20080918055501.GC4567@implementation.bordeaux.inria.fr>
In-Reply-To: <20080918055501.GC4567@implementation.bordeaux.inria.fr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Samuel Thibault wrote:
> Andreas Winkelbauer, le Thu 18 Sep 2008 01:17:20 +0000, a écrit :
>   
>> Samuel Thibault <samuel.thibault <at> ens-lyon.org> writes:
>>     
>>> Andreas Winkelbauer, le Wed 17 Sep 2008 18:50:24 +0200, a écrit :
>>>       
>>>>  /* vga.c */
>>>>  
>>>>  #ifndef TARGET_SPARC
>>>> -#define VGA_RAM_SIZE (8192 * 1024)
>>>> +#define VGA_RAM_SIZE (16 * 1024 * 1024)
>>>>  #else
>>>>         
>>> Mmm, did you check that save/restore works between before and after the
>>> change?
>>>       
>> Are there some problems due to this change?
>>     
>
> I haven't tested myself with plain qemu, but with xen ioemu I had
> troubles when I tried to change the video memory size.
>
>   
>> I would be very surprised if this change breaks save/restore, since kvm uses
>> this patch for quite a long time now and there were no complaints about
>> save/restore not working.
>>     

The problem is that a patch like this will break save/restore across 
different versions of QEMU.  The fact that this isn't easily detected is 
a problem that would be nice to fix.

Has vgabios cut a release with the patch required for this?  Does the 
KVM version of vgabios contain any other patches?

Regards,

Anthony Liguori


> Including on upgrade?
>
> Samuel
>
>
>